Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to get any unhandled exception caught by the renderer #344

Merged
merged 8 commits into from
Mar 22, 2021

Conversation

egil
Copy link
Member

@egil egil commented Mar 22, 2021

Pull request description

Add option to get any unhandled exception caught by the renderer.

Closes #319.

PR meta checklist

  • Pull request is targeted at DEV branch for code
    or targeted at main branch for documentation that is live on bunit.egilhansen.com.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@egil egil self-assigned this Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #344 (202d4c9) into dev (41773b3) will increase coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #344      +/-   ##
==========================================
+ Coverage   81.60%   81.66%   +0.05%     
==========================================
  Files         126      126              
  Lines        3805     3839      +34     
  Branches      491      495       +4     
==========================================
+ Hits         3105     3135      +30     
- Misses        541      544       +3     
- Partials      159      160       +1     
Impacted Files Coverage Δ
...bunit.web/Extensions/RenderedFragmentExtensions.cs 69.23% <ø> (ø)
...Helpers/RenderedFragmentWaitForHelperExtensions.cs 62.50% <37.50%> (-4.17%) ⬇️
...it.core/Extensions/WaitForHelpers/WaitForHelper.cs 92.70% <100.00%> (+2.93%) ⬆️
src/bunit.core/Rendering/TestRenderer.cs 90.25% <100.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41773b3...202d4c9. Read the comment docs.

@egil egil merged commit 143350b into dev Mar 22, 2021
@egil egil deleted the run-rendered-component-updates-on-test-sc branch March 22, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure exceptions thrown by components during async renders are propagated to test thread
1 participant