code cleanup

brianc · brianc · commit 0d1952233959 · 2011-05-01T21:35:00.000-05:00
diff --git a/lib/client-pool.js b/lib/client-pool.js
@@ -26,9 +26,6 @@ module.exports = {
 
       client.once('error', onError);
 
-      //TODO refactor
-      //i don't like reaching into the client's connection for attaching
-      //to specific events here
       client.once('connect', onReady);
     }
 
@@ -41,33 +38,21 @@ module.exports = {
       return defaults.poolSize;
     }
 
-    var log = function() {
-      //do nothing
-    }
-
-    //for testing
-    // var log = function() {
-    //   console.log.apply(console, arguments);
-    // }
-
     var getPooledClient = function(config, callback) {
       //lookup pool using config as key
       //TODO this don't work so hot w/ object configs
       var pool = clientPools[config];
 
       //create pool if doesn't exist
       if(!pool) {
-        //log("creating pool %s", config)
         pool = clientPools[config] = new Pool(defaults.poolSize, function() {
-          //log("creating new client in pool %s", config)
           var client = new Client(config);
           client.connected = false;
           return client;
         })
       }
 
       pool.checkOut(function(err, client) {
-
         //if client already connected just
         //pass it along to the callback and return
         if(client.connected) {
@@ -92,9 +77,6 @@ module.exports = {
 
         client.once('error', onError);
 
-        //TODO refactor
-        //i don't like reaching into the client's connection for attaching
-        //to specific events here
         client.once('connect', onReady);
 
         client.connect();
diff --git a/lib/index.js b/lib/index.js
@@ -11,6 +11,7 @@ module.exports = {
   defaults: defaults
 }
 
+//lazy require native as it may not have been built
 module.exports.__defineGetter__("native", function() {
   return require(__dirname + '/native');
 })

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ module.exports = {`
`11`	`11`	`defaults: defaults`
`12`	`12`	`}`
`13`	`13`
	`14`	`+//lazy require native as it may not have been built`
`14`	`15`	`module.exports.__defineGetter__("native", function() {`
`15`	`16`	`return require(__dirname + '/native');`
`16`	`17`	`})`