style: Use explicit imports for process.env and Buffer

eemeli · eemeli · commit 4354c4233d7f · 2024-12-30T15:58:43.000+02:00
diff --git a/config/rollup.browser-config.mjs b/config/rollup.browser-config.mjs
@@ -2,23 +2,35 @@ import babel from '@rollup/plugin-babel'
 import replace from '@rollup/plugin-replace'
 import typescript from '@rollup/plugin-typescript'
 
+/** @type {import('rollup').RollupOptions} */
 export default {
   input: {
     index: 'src/index.ts',
     util: 'src/util.ts'
   },
   output: { dir: 'browser/dist', format: 'esm', preserveModules: true },
   plugins: [
-    replace({
-      preventAssignment: true,
-      'process.env.LOG_TOKENS': String(!!process.env.LOG_TOKENS),
-      'process.env.LOG_STREAM': String(!!process.env.LOG_STREAM)
-    }),
+    replace({ preventAssignment: true }),
     babel({
       babelHelpers: 'bundled',
       presets: [['@babel/env', { modules: false }]]
     }),
-    typescript({ declaration: false, outDir: 'browser/dist' })
+    typescript({ declaration: false, outDir: 'browser/dist' }),
+    {
+      resolveId: source =>
+        ['node:buffer', 'node:process'].includes(source) ? source : null,
+      load(id) {
+        switch (id) {
+          case 'node:buffer':
+            return 'export const Buffer = null;'
+          case 'node:process':
+            return (
+              'export const emitWarning = null;' +
+              `export const env = { LOG_STREAM: ${!!process.env.LOG_STREAM}, LOG_TOKENS: ${!!process.env.LOG_TOKENS} };`
+            )
+        }
+      }
+    }
   ],
   treeshake: { moduleSideEffects: false, propertyReadSideEffects: false }
 }
diff --git a/config/rollup.node-config.mjs b/config/rollup.node-config.mjs
@@ -62,6 +62,7 @@ export default [
       esModule: false,
       preserveModules: true
     },
+    external: ['node:buffer', 'node:process'],
     plugins: [
       typescript({
         transformers: { afterDeclarations: [fixDeclarationImportPaths] }
diff --git a/src/log.ts b/src/log.ts
@@ -1,3 +1,5 @@
+import { emitWarning } from 'node:process'
+
 export type LogLevelId = 'silent' | 'error' | 'warn' | 'debug'
 
 export function debug(logLevel: LogLevelId, ...messages: any[]) {
@@ -6,8 +8,7 @@ export function debug(logLevel: LogLevelId, ...messages: any[]) {
 
 export function warn(logLevel: LogLevelId, warning: string | Error) {
   if (logLevel === 'debug' || logLevel === 'warn') {
-    if (typeof process !== 'undefined' && process.emitWarning)
-      process.emitWarning(warning)
+    if (typeof emitWarning === 'function') emitWarning(warning)
     else console.warn(warning)
   }
 }
diff --git a/src/parse/parser.ts b/src/parse/parser.ts
@@ -1,3 +1,4 @@
+import { env } from 'node:process'
 import type {
   SourceToken,
   Token,
@@ -187,7 +188,7 @@ export class Parser {
    */
   *next(source: string) {
     this.source = source
-    if (process.env.LOG_TOKENS) console.log('|', prettyToken(source))
+    if (env.LOG_TOKENS) console.log('|', prettyToken(source))
 
     if (this.atScalar) {
       this.atScalar = false
diff --git a/src/schema/yaml-1.1/binary.ts b/src/schema/yaml-1.1/binary.ts
@@ -1,3 +1,4 @@
+import { Buffer } from 'node:buffer'
 import { Scalar } from '../../nodes/Scalar.ts'
 import { stringifyString } from '../../stringify/stringifyString.ts'
 import type { ScalarTag } from '../types.ts'

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+import { emitWarning } from 'node:process'`
	`2`	`+`
`1`	`3`	`export type LogLevelId = 'silent' \| 'error' \| 'warn' \| 'debug'`
`2`	`4`
`3`	`5`	`export function debug(logLevel: LogLevelId, ...messages: any[]) {`
`@@ -6,8 +8,7 @@ export function debug(logLevel: LogLevelId, ...messages: any[]) {`
`6`	`8`
`7`	`9`	`export function warn(logLevel: LogLevelId, warning: string \| Error) {`
`8`	`10`	`if (logLevel === 'debug' \|\| logLevel === 'warn') {`
`9`		`- if (typeof process !== 'undefined' && process.emitWarning)`
`10`		`- process.emitWarning(warning)`
	`11`	`+ if (typeof emitWarning === 'function') emitWarning(warning)`
`11`	`12`	`else console.warn(warning)`
`12`	`13`	`}`
`13`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+import { Buffer } from 'node:buffer'`
`1`	`2`	`import { Scalar } from '../../nodes/Scalar.ts'`
`2`	`3`	`import { stringifyString } from '../../stringify/stringifyString.ts'`
`3`	`4`	`import type { ScalarTag } from '../types.ts'`