Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with latest firedrake version #181

Open
maxweissenbacher opened this issue May 15, 2024 · 5 comments
Open

Incompatibility with latest firedrake version #181

maxweissenbacher opened this issue May 15, 2024 · 5 comments
Assignees
@ludgerpaehler
Labels
bug Something isn't working firedrake priority High-priority core feature

Comments

@maxweissenbacher
Copy link

Hi there,

simple thing: just installed the latest version of Firedrake. When trying to import

import hydrogym.firedrake as hgym

I get the following error:

ImportError: cannot import name 'atan_2' from 'ufl'

This is because the relevant function is called 'atan2' now (presumably it was called 'atan_2' in a previous version of Firedrake.

Just thought I'd let you know.
@maxweissenbacher
Copy link
Author

Also as a side remark, if you're using an older version of Firedrake it would be helpful if you could specify what version that is in the docs!

@ludgerpaehler
Copy link
Collaborator

Hey, sorry about that - just to confirm, you are building Firedrake straight from the current main right?

@ludgerpaehler
Copy link
Collaborator

(I.e. from the GitHub repository, or the latest released?)

@ludgerpaehler ludgerpaehler self-assigned this May 16, 2024
@ludgerpaehler
Copy link
Collaborator

Patch incoming later today :)

@ludgerpaehler ludgerpaehler added bug Something isn't working priority High-priority core feature firedrake labels May 16, 2024
@dmitryshribak
Copy link

Same issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludgerpaehler ludgerpaehler

Labels
bug Something isn't working firedrake priority High-priority core feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ludgerpaehler @dmitryshribak @maxweissenbacher