feat: switch to FrankenPHP #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be "better" to add this as an alternative/parallel option (for example in a separate Dockerfile or at least a separate stage), besides php-fpm, especially because of this part in the readme:
Starting to use dockerized PHP can be a large step for newcomers, but in parallel going away from well-known php-fpm... could be a showstopper for some (too adventurous) |
jdreesen
reviewed
Sep 14, 2023
dunglas
force-pushed
the
feat/frankenphp
branch
2 times, most recently
from
fab0faa to
dfa0929
Compare
|
@bzoks I plan to create an |
dunglas
force-pushed
the
feat/frankenphp
branch
4 times, most recently
from
42b90f9 to
0547c62
Compare
dunglas
force-pushed
the
feat/frankenphp
branch
from
0547c62 to
abe5609
Compare
senzowayne
reviewed
Sep 15, 2023
dunglas
force-pushed
the
feat/frankenphp
branch
from
ea06b84 to
3161261
Compare
AchillesKal
pushed a commit
to AchillesKal/php-docker
that referenced
this pull request
Nov 28, 2023
LucasHospice
pushed a commit
to LucasHospice/symfony-docker
that referenced
this pull request
Feb 21, 2024
VitaliyMinenko
pushed a commit
to VitaliyMinenko/notofication-service
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FrankenPHP 🎉