Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit information that the frankenphp_handle_request function was not called #1236

Open
7-zete-7 opened this issue Dec 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@7-zete-7
Copy link

7-zete-7 commented Dec 9, 2024

Currently, if the frankenphp_handle_request function is not called, FrankenPHP is restarted cyclically (see dunglas/symfony-docker#708).

It would be nice if FrankenPHP could notify the developer more explicitly that the function was not called.

@AlliBalliBaba
Copy link
Collaborator

I think this could be coupled with being able to configure the max amount of calls to frankenphp_handle_request in the Caddy config.

And if there have been no calls, we can log an error or panic, not sure which one's better.

@dunglas
Copy link
Owner

dunglas commented Dec 9, 2024

To keep things simple, I would prefer to just log an error if the script exits without having call the function.

Configuring the maximum number of requests to handle is already possible (and done) user land. Let’ try to keep the core as small and focused as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants