-
-
Notifications
You must be signed in to change notification settings - Fork 46
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: dry-rb/dry-initializer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.1.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: dry-rb/dry-initializer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.1.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 16 files changed
- 3 contributors
Commits on Jan 17, 2022
-
Update .rubocop.yml from dry-rb/template-gem
File Sync committedJan 17, 2022 Configuration menu - View commit details
-
Copy full SHA for 2282b40 - Browse repository at this point
Copy the full SHA 2282b40View commit details -
Update Gemfile.devtools from dry-rb/template-gem
File Sync committedJan 17, 2022 Configuration menu - View commit details
-
Copy full SHA for cb30d1a - Browse repository at this point
Copy the full SHA cb30d1aView commit details
Commits on Jan 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 730b9bc - Browse repository at this point
Copy the full SHA 730b9bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69a8d00 - Browse repository at this point
Copy the full SHA 69a8d00View commit details -
Revert adding field name to constraint error
There's a bunch of problems with that improvement: 1. It changes the type of error that is thrown by dry-types. It broke rom's specs (though I would argue it wasn't declared as part of the public interface and rom shouldn't have committed to a specific error) 2. It refers to dry-types explicitly though it wasn't a hard dependency. The following example fails with `uninitialized constant Dry::Types`: ``` class Foo extend Dry::Initializer param :foo, type: proc { Integer(_1) } end Foo.new('abc') ``` I decided we should ship 3.1.1 without this change and think the whole thing through. Probably, we should add a dry-types extension to dry-initializer that improves errors but requires explicit activation.
Configuration menu - View commit details
-
Copy full SHA for 679014f - Browse repository at this point
Copy the full SHA 679014fView commit details
Commits on Jan 19, 2022
-
Merge pull request #95 from dry-rb/revert-rescueing-dry-types
Revert adding field name to constraint error
Configuration menu - View commit details
-
Copy full SHA for 8359a12 - Browse repository at this point
Copy the full SHA 8359a12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16aa743 - Browse repository at this point
Copy the full SHA 16aa743View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14b2384 - Browse repository at this point
Copy the full SHA 14b2384View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e81f28 - Browse repository at this point
Copy the full SHA 3e81f28View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.1.0...v3.1.1