Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dry-rb/dry-initializer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.1.0
Choose a base ref
...
head repository: dry-rb/dry-initializer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.1.1
Choose a head ref
  • 9 commits
  • 16 files changed
  • 3 contributors

Commits on Jan 17, 2022

  1. Update .rubocop.yml from dry-rb/template-gem

    File Sync committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    2282b40 View commit details
    Browse the repository at this point in the history
  2. Update Gemfile.devtools from dry-rb/template-gem

    File Sync committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    cb30d1a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. rubocop -a

    flash-gordon committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    730b9bc View commit details
    Browse the repository at this point in the history
  2. Add bin/console

    flash-gordon committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    69a8d00 View commit details
    Browse the repository at this point in the history
  3. Revert adding field name to constraint error

    There's a bunch of problems with that improvement:
    
    1. It changes the type of error that is thrown by dry-types. It broke rom's specs (though I would argue it wasn't declared as part of the public interface and rom shouldn't have committed to a specific error)
    2. It refers to dry-types explicitly though it wasn't a hard dependency. The following example fails with `uninitialized constant Dry::Types`:
    ```
    class Foo
      extend Dry::Initializer
    
      param :foo, type: proc { Integer(_1) }
    end
    
    Foo.new('abc')
    ```
    
    I decided we should ship 3.1.1 without this change and think the whole thing through. Probably, we should add a dry-types extension to dry-initializer that improves errors but requires explicit activation.
    flash-gordon committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    679014f View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Merge pull request #95 from dry-rb/revert-rescueing-dry-types

    Revert adding field name to constraint error
    flash-gordon authored Jan 19, 2022
    Configuration menu
    Copy the full SHA
    8359a12 View commit details
    Browse the repository at this point in the history
  2. Bump version to 3.1.1

    flash-gordon committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    16aa743 View commit details
    Browse the repository at this point in the history
  3. Update changelog

    flash-gordon committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    14b2384 View commit details
    Browse the repository at this point in the history
  4. [devtools] sync

    dry-bot committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    3e81f28 View commit details
    Browse the repository at this point in the history
Loading