Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htmlInstaller - always looks up for index.html in current ("downloads..") directory #152

Open
remy-bcz opened this issue May 16, 2022 · 3 comments

Comments

@remy-bcz
Copy link

Hi,
There is a problem with web installer build with htmlInstaller.exe template (".\InstallerLinker.exe" /Template:"C:\Program Files (x86)\dotNetInstaller\bin\htmlInstaller.exe" [..]).

Web installer (built from htmlInstaller.exe) is usually downloaded from web page into "Downloads.." directory by user and run from that directory.
Web installer displays at start "index.html" file loaded from current directory or from embeded resources (https://github.com/dotnetinstaller/dotnetinstaller/blob/master/htmlInstaller/HtmlWindow.cpp lines 72 - 86).

The problem occures when user previously download any file named "index.html" and save it in default download directory which is no so rare.

As a solution I would like to have an option for InstallerLinker to ignore local files and use only embeded files, or have an option in configuration to change file name form "index.html" to someting much more unique (i.e. "[some guid].html")

@dblock dblock added the bug? label May 16, 2022
@dblock
Copy link
Collaborator

dblock commented May 16, 2022

Without looking at the code, anything run/extracted should go into a new temporary directory and not overwrite or try to open something that was already there.

@remy-bcz
Copy link
Author

This feature (opening from current folder instead of embeded resources) is usefull, but only on testing stage - when you need to quickly fix html or css without rebuilding webinstaller.

It should be disabled after final webinstaller is released to production.

@dblock
Copy link
Collaborator

dblock commented May 16, 2022

Makes sense. Please contribute as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants