Flatten SourceMethodSymbol hierarchy #76107
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
| @@ -1746,5 +1746,78 @@ internal override System.Reflection.MethodImplAttributes ImplementationAttribute | |||
|
|
|||
| internal override int TryGetOverloadResolutionPriority() | |||
| => GetEarlyDecodedWellKnownAttributeData()?.OverloadResolutionPriority ?? 0; | |||
|
|
|||
There was a problem hiding this comment.
These methods were copy/pasted from SourceMethodSymbol.cs with no changes to their content.
Once upon a time, there were source method symbols that didn't have attributes, and thus we had `SourceMethodSymbol` and `SourceMethodSymbolWithAttributes`, to simplify/save on symbol size for such methods. Today, there is no such difference, and the only direct implementor of `SourceMethodSymbol` is `SourceMethodSymbolWithAttributes`. Therefore, I've cleaned up the hierarchy by removing the dead intermediate class.
333fred
force-pushed
the
flatten-sourcemethodsymbol
branch
from
7edad91 to
330af76
Compare
|
@cston @jcouv, I've taken advice from Aleksey and restructured the approach to keep everything in the same location; instead, I now just make SourceMethodSymbol a |
There was a problem hiding this comment.
Should we also rename the file? Perhaps to SourceMethodSymbol_Attributes.cs
There was a problem hiding this comment.
The goal with this version was to reduce noise in git history, so I didn't.
There was a problem hiding this comment.
Git would likely detect it as rename, so there would be no noise
Once upon a time, there were source method symbols that didn't have attributes, and thus we had
SourceMethodSymbolandSourceMethodSymbolWithAttributes, to simplify/save on symbol size for such methods. Today, there is no such difference, and the only direct implementor ofSourceMethodSymbolisSourceMethodSymbolWithAttributes. Therefore, I've cleaned up the hierarchy by removing the dead intermediate class. Highly suggest reviewing commit-by-commit, so that the rename-with-no-changes is correctly displayed. I will not be squash merging this PR to preserve that rename in history as well.