Skip to content

Commit d6d3800

Browse files
authored
fix(android): make button default text not all caps for improved consistency (NativeScript#10854)
1 parent eef1503 commit d6d3800

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"eslint": "~8.57.0",
6262
"eslint-config-prettier": "^10.0.0",
6363
"fork-ts-checker-webpack-plugin": "^7.0.0",
64-
"form-data": ">=4.0.4",
64+
"form-data": ">=4.0.4",
6565
"gonzales": "^1.0.7",
6666
"husky": "^9.0.0",
6767
"jest": "30.0.5",
@@ -104,12 +104,12 @@
104104
"zx": "^8.3.0",
105105
"jest-util": "30.0.5"
106106
},
107-
"overrides": {
108-
"form-data": ">=4.0.4"
109-
},
107+
"overrides": {
108+
"form-data": ">=4.0.4"
109+
},
110110
"lint-staged": {
111111
"**/*.{js,ts,css,scss,json,html}": [
112112
"npx prettier --write"
113113
]
114114
}
115-
}
115+
}

packages/core/ui/button/index.android.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ export class Button extends ButtonBase {
7575
public initNativeView(): void {
7676
super.initNativeView();
7777
const nativeView = this.nativeViewProtected;
78+
// make consistent with iOS, easier on users given css styling
79+
nativeView.setAllCaps(false);
7880
initializeClickListener();
7981
const clickListener = new ClickListener(this);
8082
nativeView.setOnClickListener(clickListener);

0 commit comments

Comments
 (0)