Skip to content

Resolve LSP violation #11520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greg0ire wants to merge 2 commits into from
Closed

Resolve LSP violation #11520

greg0ire wants to merge 2 commits into from

Conversation

@greg0ire
Copy link
Member

@greg0ire greg0ire commented Jun 22, 2024

This was necessary to support usage of static reflection, which is gone
with ORM 3.

greg0ire added 2 commits June 22, 2024 11:39
@greg0ire
Remove DatabaseDriver
2c489fb
@greg0ire
Resolve LSP violation
c230f8b 
This was necessary to support usage of static reflection, which is gone
with ORM 3.
@greg0ire
Copy link
Member Author

greg0ire commented Jun 22, 2024

@stof Psalm now rightfully complains about this line:

orm/src/Mapping/ClassMetadata.php

Line 785 in 1153b94

$this->reflClass = $reflService->getClass($this->name);

What should I do?

More broadly, is https://github.com/doctrine/persistence/blob/3.3.x/src/Persistence/Mapping/StaticReflectionService.php still needed? Should null be removed from the return type of https://github.com/doctrine/persistence/blob/b337726451f5d530df338fc7f68dee8781b49779/src/Persistence/Mapping/ReflectionService.php#L51-L56 ?

@greg0ire
Copy link
Member Author

greg0ire commented Jun 22, 2024

Related to doctrine/persistence#379

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Oct 15, 2024
@greg0ire
Copy link
Member Author

greg0ire commented Oct 15, 2024

Looks like the issue I was concerned about was resolved in doctrine/persistence#381. I think I need to work on releasing persistence 4.0.0 before working on this 🤔

@github-actions github-actions bot removed the Stale label Oct 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Jan 22, 2025
@greg0ire
Copy link
Member Author

greg0ire commented Jan 22, 2025

Handled in #11729

@greg0ire greg0ire closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@greg0ire