Feature/json import #777
Closed
Feature/json import #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hironsan
reviewed
May 21, 2020
| @@ -390,6 +390,30 @@ def parse(self, file): | |||
| if data: | |||
| yield data | |||
|
|
|||
| raise FileParseException(line_num=i, line=line) | ||
|
|
||
| if data: | ||
| yield data | ||
|
|
app/api/utils.py
Outdated
| file = io.TextIOWrapper(file, encoding=file.encoding) | ||
| data = [] | ||
| for i, line in enumerate(file, start=1): | ||
| #Remove trailing new line and comma |
app/api/utils.py
Outdated
| for i, line in enumerate(file, start=1): | ||
| #Remove trailing new line and comma | ||
| line = line.rstrip('\n').rstrip(',') | ||
| #Skip first and last line |
app/api/utils.py
Outdated
| @@ -390,6 +390,30 @@ def parse(self, file): | |||
| if data: | |||
| yield data | |||
|
|
|||
| class JSONParser(FileParser): | |||
There was a problem hiding this comment.
JSONParser is not enough to parse JSON file. For example:
[{"text": "Terrible customer service.", "labels": ["negative"]},{"text": "Really great transaction.", "labels": ["positive"]},{"text": "Great price.", "labels": ["\
positive"]}]
cgill95
force-pushed
the
feature/json_import
branch
from
ac9ed0e
to
23885bc
Compare
|
@Hironsan the JSONParser now works with all kind of JSON lines as well as nested structures that include the "meta" keyword. Hopefully this can be merged into the master now. |
cgill95
force-pushed
the
feature/json_import
branch
from
51f743d
to
6781366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#454
Implementation of the requested JSON import such that JSON and JSONL can be chosen as import options