fix(document): set content field to none clear all attributes (#220)

hanxiao · web-flow · commit 6d2093ff9176 · 2022-03-22T22:59:05.000+01:00
diff --git a/docarray/document/mixins/property.py b/docarray/document/mixins/property.py
@@ -25,17 +25,20 @@ def content(self) -> Optional['DocumentContentType']:
 
     @_PropertyMixin.text.setter
     def text(self, value: str):
-        self._clear_content()
+        if value is not None:
+            self._clear_content()
         self._data.text = value
 
     @_PropertyMixin.blob.setter
     def blob(self, value: bytes):
-        self._clear_content()
+        if value is not None:
+            self._clear_content()
         self._data.blob = value
 
     @_PropertyMixin.tensor.setter
     def tensor(self, value: 'ArrayType'):
-        self._clear_content()
+        if value is not None:
+            self._clear_content()
         self._data.tensor = value
 
     @content.setter
diff --git a/tests/unit/array/test_base_getsetdel.py b/tests/unit/array/test_base_getsetdel.py
@@ -81,3 +81,21 @@ def test_getter_int_str(docs):
 
     with pytest.raises(KeyError):
         docs['adsad']
+
+
+def test_set_content_none():
+    da = DocumentArray(
+        [
+            Document(mime_type='image'),
+            Document(mime_type='image'),
+            Document(mime_type='text'),
+        ]
+    )
+
+    txt_da = da.find({'mime_type': {'$eq': 'image'}})
+    assert len(txt_da) == 2
+    txt_da.texts = ['hello', 'world']
+    assert txt_da.texts == ['hello', 'world']
+    assert da.texts == ['hello', 'world', '']
+    da.tensors = None
+    assert da.texts == ['hello', 'world', '']
