fix: reconstruct from proper type

Joan Fontanals Martinez · Joan Fontanals Martinez · commit 4f6c270eb2f3 · 2023-07-27T04:33:07.000+02:00
diff --git a/docarray/index/backends/hnswlib.py b/docarray/index/backends/hnswlib.py
@@ -571,16 +571,15 @@ def _doc_from_bytes(
     ) -> BaseDoc:
         schema = self.out_schema if out else self._schema
         schema_cls = cast(Type[BaseDoc], schema)
-        pb = DocProto.FromString(data)
+        pb = DocProto.FromString(
+            data
+        )  # I cannot reconstruct directly the DA object because it may fail at validation because embedding may not be Optional
         for k, v in reconstruct_embeddings.items():
-            nd_proto = NdArrayProto()
-            np_array = np.array(v)
-            nd_proto.dense.buffer = np_array.tobytes()
-            nd_proto.dense.ClearField('shape')
-            nd_proto.dense.shape.extend(list(np_array.shape))
-            nd_proto.dense.dtype = np_array.dtype.str
-            node_proto = NodeProto(ndarray=nd_proto, type='ndarray')
-
+            node_proto = (
+                self.out_schema.__fields__[k]
+                .type_.from_ndarray(np.array(v))
+                ._to_node_protobuf()
+            )
             pb.data[k].MergeFrom(node_proto)
 
         doc = schema_cls.from_protobuf(pb)
