perf: optimize document getter

hanxiao · hanxiao · commit 4b21689366f4 · 2022-03-09T21:42:56.000+01:00
diff --git a/docarray/array/storage/base/seqlike.py b/docarray/array/storage/base/seqlike.py
@@ -13,15 +13,15 @@ def insert(self, index: int, value: 'Document'):
         :param index: Position of the insertion.
         :param value: The doc needs to be inserted.
         """
-        self._set_doc_by_id(None, value)
+        self._set_doc_by_id(value.id, value)
         self._offset2ids.insert(index, value.id)
 
     def append(self, value: 'Document'):
         """Append `doc` to the end of the array.
 
         :param value: The doc needs to be appended.
         """
-        self._set_doc_by_id(None, value)
+        self._set_doc_by_id(value.id, value)
         self._offset2ids.append(value.id)
 
     @abstractmethod
diff --git a/docarray/array/storage/memory/getsetdel.py b/docarray/array/storage/memory/getsetdel.py
@@ -17,7 +17,7 @@ def _del_doc_by_id(self, _id: str):
 
     def _set_doc_by_id(self, _id: str, value: 'Document'):
         _vid = value.id
-        if _id is not None and _id != _vid:
+        if _id != _vid:
             del self._data[_id]
         self._data[_vid] = value
 
