fix: fix the hnswlib tests

Joan Fontanals Martinez · Joan Fontanals Martinez · commit 46bcf5a5cf02 · 2023-07-31T17:53:10.000+02:00
Signed-off-by: Joan Fontanals Martinez &lt;joan.martinez@jina.ai&gt;
diff --git a/docarray/index/backends/elasticv7.py b/docarray/index/backends/elasticv7.py
@@ -130,19 +130,6 @@ def execute_query(self, query: Dict[str, Any], *args, **kwargs) -> Any:
     # Helpers                                     #
     ###############################################
 
-    # ElasticSearch helpers
-    def _create_index_mapping(self, col: '_ColumnInfo') -> Dict[str, Any]:
-        """Create a new HNSW index for a column, and initialize it."""
-
-        index = col.config.copy()
-        if 'type' not in index:
-            index['type'] = col.db_type
-
-        if col.db_type == 'dense_vector' and col.n_dim:
-            index['dims'] = col.n_dim
-
-        return index
-
     def _form_search_body(self, query: np.ndarray, limit: int, search_field: str = '') -> Dict[str, Any]:  # type: ignore
         body = {
             'size': limit,
diff --git a/docarray/index/backends/hnswlib.py b/docarray/index/backends/hnswlib.py
@@ -115,7 +115,7 @@ def __init__(self, db_config=None, **kwargs):
                 sub_docs_exist = True
             if safe_issubclass(col.docarray_type, AnyDocArray):
                 continue
-            if not col.config:
+            if not col.config or 'dim' not in col.config:
                 # non-tensor type; don't create an index
                 continue
             if not load_existing and (
diff --git a/tests/index/base_classes/test_base_doc_store.py b/tests/index/base_classes/test_base_doc_store.py
@@ -157,7 +157,7 @@ def test_create_columns():
     assert index._column_infos['id'].docarray_type == ID
     assert index._column_infos['id'].db_type == str
     assert index._column_infos['id'].n_dim is None
-    assert index._column_infos['id'].config == {'hi': 'there'}
+    assert index._column_infos['id'].config['hi'] == 'there'
 
     assert issubclass(index._column_infos['tens'].docarray_type, AbstractTensor)
     assert index._column_infos['tens'].db_type == str
@@ -171,7 +171,7 @@ def test_create_columns():
     assert index._column_infos['id'].docarray_type == ID
     assert index._column_infos['id'].db_type == str
     assert index._column_infos['id'].n_dim is None
-    assert index._column_infos['id'].config == {'hi': 'there'}
+    assert index._column_infos['id'].config['hi'] == 'there'
 
     assert issubclass(index._column_infos['tens_one'].docarray_type, AbstractTensor)
     assert index._column_infos['tens_one'].db_type == str
@@ -190,7 +190,7 @@ def test_create_columns():
     assert index._column_infos['id'].docarray_type == ID
     assert index._column_infos['id'].db_type == str
     assert index._column_infos['id'].n_dim is None
-    assert index._column_infos['id'].config == {'hi': 'there'}
+    assert index._column_infos['id'].config['hi'] == 'there'
 
     assert issubclass(index._column_infos['d__tens'].docarray_type, AbstractTensor)
     assert index._column_infos['d__tens'].db_type == str
@@ -214,7 +214,7 @@ def test_create_columns():
     assert index._subindices['d']._column_infos['id'].docarray_type == ID
     assert index._subindices['d']._column_infos['id'].db_type == str
     assert index._subindices['d']._column_infos['id'].n_dim is None
-    assert index._subindices['d']._column_infos['id'].config == {'hi': 'there'}
+    assert index._subindices['d']._column_infos['id'].config['hi'] == 'there'
 
     assert issubclass(
         index._subindices['d']._column_infos['tens'].docarray_type, AbstractTensor
@@ -262,10 +262,10 @@ def test_create_columns():
     assert (
         index._subindices['d_root']._subindices['d']._column_infos['id'].n_dim is None
     )
-    assert index._subindices['d_root']._subindices['d']._column_infos['id'].config == {
-        'hi': 'there'
-    }
-
+    assert (
+        index._subindices['d_root']._subindices['d']._column_infos['id'].config['hi']
+        == 'there'
+    )
     assert issubclass(
         index._subindices['d_root']
         ._subindices['d']
