fix: ws scheme (#210)

hanxiao · web-flow · commit 3380b3be1ae5 · 2022-03-16T11:15:24.000+01:00
diff --git a/docarray/array/mixins/post.py b/docarray/array/mixins/post.py
@@ -18,14 +18,15 @@ def post(
 
         :param host: a host string. Can be one of the following:
             - `grpc://192.168.0.123:8080/endpoint`
-            - `websocket://192.168.0.123:8080/endpoint`
+            - `ws://192.168.0.123:8080/endpoint`
             - `http://192.168.0.123:8080/endpoint`
             - `jinahub://Hello/endpoint`
             - `jinahub+docker://Hello/endpoint`
             - `jinahub+sandbox://Hello/endpoint`
 
         :param show_progress: if to show a progressbar
         :param batch_size: number of Document on each request
+        :param parameters: parameters to send in the request
         :return: the new DocumentArray returned from remote
         """
 
@@ -56,7 +57,7 @@ def post(
                     request_size=batch_size,
                     parameters=parameters,
                 )
-        elif r.scheme in ('grpc', 'http', 'websocket'):
+        elif r.scheme in ('grpc', 'http', 'ws'):
             if _port is None:
                 raise ValueError(f'can not determine port from {host}')
 
diff --git a/tests/unit/array/mixins/test_post.py b/tests/unit/array/mixins/test_post.py
@@ -12,7 +12,7 @@
     [
         (dict(protocol='grpc'), 'grpc://127.0.0.1:$port/'),
         (dict(protocol='grpc'), 'grpc://127.0.0.1:$port'),
-        (dict(protocol='websocket'), 'websocket://127.0.0.1:$port'),
+        (dict(protocol='websocket'), 'ws://127.0.0.1:$port'),
         # (dict(protocol='http'), 'http://127.0.0.1:$port'),  this somehow does not work on GH workflow
     ],
 )

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`[`
`13`	`13`	`(dict(protocol='grpc'), 'grpc://127.0.0.1:$port/'),`
`14`	`14`	`(dict(protocol='grpc'), 'grpc://127.0.0.1:$port'),`
`15`		`- (dict(protocol='websocket'), 'websocket://127.0.0.1:$port'),`
	`15`	`+ (dict(protocol='websocket'), 'ws://127.0.0.1:$port'),`
`16`	`16`	`# (dict(protocol='http'), 'http://127.0.0.1:$port'), this somehow does not work on GH workflow`
`17`	`17`	`],`
`18`	`18`	`)`