FIX: redis.setex() expects seconds parameter not DateTime (#36238)

keegangeorge · web-flow · commit c1e322048d21 · 2025-11-25T15:47:41.000-08:00
## &#128269; Overview

This update fixes a bug in chat's `set_replies_count_redis_cache`
method.

`Discourse.redis.setex()` expects the 2nd parameter to be a seconds
value not a `DateTime` value as an integer. This was causing thread
cache keys to last for numerous years instead of 5 mintues in Redis. The
value should be 300 seconds (5 minutes) instead of `5.minutes.from_now`
date/time getting converted to an integer.
diff --git a/plugins/chat/app/models/concerns/chat/thread_cache.rb b/plugins/chat/app/models/concerns/chat/thread_cache.rb
@@ -59,7 +59,7 @@ def set_replies_count_cache(value, update_db: false)
     def set_replies_count_redis_cache(value)
       Discourse.redis.setex(
         Chat::Thread.replies_count_cache_redis_key(self.id),
-        5.minutes.from_now.to_i,
+        5.minutes.to_i,
         value,
       )
     end

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ def set_replies_count_cache(value, update_db: false)`
`59`	`59`	`def set_replies_count_redis_cache(value)`
`60`	`60`	`Discourse.redis.setex(`
`61`	`61`	`Chat::Thread.replies_count_cache_redis_key(self.id),`
`62`		`- 5.minutes.from_now.to_i,`
	`62`	`+ 5.minutes.to_i,`
`63`	`63`	`value,`
`64`	`64`	`)`
`65`	`65`	`end`