FIX: AI search discoveries user preference not saving

ZogStriP · ZogStriP · commit 96d7e6bcac6e · 2025-12-12T18:38:53.000+01:00
The "Enable AI search discoveries" checkbox in user preferences
wasn't persisting changes. The UI showed "saved" but the value
never reached the database.

The Interface controller's `saveAttrNames` is a computed property
that returns a new array on each access. While the plugin called
`addSaveableUserOptionField()`, this only registers the field with
the User model. The controller filters which fields to save via
`saveAttrNames`, and since `ai_search_discoveries` wasn't in that
list, it was excluded from the save request.

Fix by using `modifyClass` to extend the controller's `save()`
action, pushing `ai_search_discoveries` to `saveAttrNames` at the
moment of saving before calling the parent method.

Ref - meta/t/391135
diff --git a/plugins/discourse-ai/assets/javascripts/discourse/initializers/ai-search-discoveries.js b/plugins/discourse-ai/assets/javascripts/discourse/initializers/ai-search-discoveries.js
@@ -1,5 +1,8 @@
+import { action } from "@ember/object";
 import { apiInitializer } from "discourse/lib/api";
 
+const FIELD_NAME = "ai_search_discoveries";
+
 export default apiInitializer((api) => {
   const currentUser = api.getCurrentUser();
   const settings = api.container.lookup("service:site-settings");
@@ -11,7 +14,19 @@ export default apiInitializer((api) => {
     return;
   }
 
-  api.addSaveableUserOptionField("ai_search_discoveries");
+  api.addSaveableUserOptionField(FIELD_NAME);
+
+  api.modifyClass(
+    "controller:preferences/interface",
+    (Superclass) =>
+      class extends Superclass {
+        @action
+        save() {
+          this.saveAttrNames.push(FIELD_NAME);
+          return super.save(...arguments);
+        }
+      }
+  );
 
   const discobotDiscoveries = api.container.lookup(
     "service:discobot-discoveries"
diff --git a/plugins/discourse-ai/spec/system/ai_user_preferences_spec.rb b/plugins/discourse-ai/spec/system/ai_user_preferences_spec.rb
@@ -25,6 +25,19 @@
         expect(user_preferences_ai_page).to have_ai_preference("pref-ai-search-discoveries")
       end
 
+      it "saves the setting when toggled" do
+        user.user_option.update!(ai_search_discoveries: true)
+        user_preferences_ai_page.visit(user)
+
+        expect(user_preferences_ai_page).to have_ai_preference_checked("pref-ai-search-discoveries")
+
+        user_preferences_ai_page.toggle_setting("pref-ai-search-discoveries")
+        user_preferences_ai_page.save_changes
+
+        expect(page).to have_content(I18n.t("js.saved"))
+        expect(user.user_option.reload.ai_search_discoveries).to eq(false)
+      end
+
       context "when the user can't use personas" do
         it "doesn't render the option in the preferences page" do
           Group.find_by(id: Group::AUTO_GROUPS[:admins]).remove(user)
