Commit 95643f5
authored
FIX: silent option not working for bulk category moves via PostRevisor (#36626)
The `silent` option for bulk category changes was not being respected
when `create_revision_on_bulk_topic_moves` was enabled. This caused
users watching the destination category to receive notifications even
when the "Perform this action silently" checkbox was checked.
The bug was introduced in commit 7a099eb which added `silent: @silent`
to the `track_topic_field(:category_id)` block. However, since blocks
capture `self` at definition time (the class, not the instance), `@silent`
was always nil in that context.
The fix passes the `silent` value through the `TopicChanges` object which
is already available to the block as `tc`.
Also extends test coverage to verify both topic watchers and category
watchers are properly silenced in both code paths.
Ref - meta/t/3909931 parent 3997ce5 commit 95643f5
2 files changed
+295
-337
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
96 | 98 | | |
97 | 99 | | |
98 | 100 | | |
99 | | - | |
| 101 | + | |
100 | 102 | | |
101 | 103 | | |
102 | 104 | | |
| |||
283 | 285 | | |
284 | 286 | | |
285 | 287 | | |
| 288 | + | |
286 | 289 | | |
287 | 290 | | |
288 | 291 | | |
| |||
0 commit comments