FIX: do not prepend #fragment with https:// on link modal (#36619)

renato · web-flow · commit 44395c22fdd8 · 2025-12-11T00:53:28.000-03:00
`prefixProtocol` is used by the upsert hyperlink modal, it was
prepending `https://` to URLs starting with `#fragment`, which can be
used for topic anchoring.

This PR changes `prefixProtocol` so it doesn't prepend `https://` for
strings started with a `#`.
diff --git a/frontend/discourse/app/lib/url.js b/frontend/discourse/app/lib/url.js
@@ -503,7 +503,12 @@ export function prefixProtocol(url) {
     return `https:${url}`;
   }
 
-  if (url.startsWith("/") || url.includes("://") || url.startsWith("mailto:")) {
+  if (
+    url.startsWith("/") ||
+    url.includes("://") ||
+    url.startsWith("mailto:") ||
+    url.startsWith("#")
+  ) {
     return url;
   }
 
diff --git a/frontend/discourse/tests/unit/lib/url-test.js b/frontend/discourse/tests/unit/lib/url-test.js
@@ -218,6 +218,7 @@ module("Unit | Utility | url", function (hooks) {
       "ftp://www.discourse.org"
     );
     assert.strictEqual(prefixProtocol("/my/preferences"), "/my/preferences");
+    assert.strictEqual(prefixProtocol("#anchor-fragment"), "#anchor-fragment");
   });
 
   test("getCategoryAndTagUrl", function (assert) {

Original file line number	Diff line number	Diff line change
`@@ -503,7 +503,12 @@ export function prefixProtocol(url) {`
`503`	`503`	return `https:${url}`;
`504`	`504`	`}`
`505`	`505`
`506`		`- if (url.startsWith("/") \|\| url.includes("://") \|\| url.startsWith("mailto:")) {`
	`506`	`+ if (`
	`507`	`+ url.startsWith("/") \|\|`
	`508`	`+ url.includes("://") \|\|`
	`509`	`+ url.startsWith("mailto:") \|\|`
	`510`	`+ url.startsWith("#")`
	`511`	`+ ) {`
`507`	`512`	`return url;`
`508`	`513`	`}`
`509`	`514`