Skip to content

Commit 2677ac1

Browse files
DEV: Use existing image for logo in tests (#36627)
Stops the 404 errors in qunit tests
1 parent bbae453 commit 2677ac1

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

frontend/discourse/tests/acceptance/image-aspect-ratio-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ acceptance("Image aspect ratio", function () {
77
await visit("/t/2480");
88

99
assert
10-
.dom("#post_3 img[src='/assets/logo.png']")
10+
.dom("#post_3 img[src='/images/discourse-logo-sketch.png']")
1111
.hasStyle({ aspectRatio: "690 / 388" });
1212
});
1313
});

frontend/discourse/tests/acceptance/transformers/home-logo-image-url-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ acceptance("home-logo-image-url transformer", function () {
1818
.dom("#site-logo")
1919
.hasAttribute(
2020
"src",
21-
"/transformed/assets/logo.png",
21+
"/transformed/images/discourse-logo-sketch.png",
2222
"it transforms the logo url"
2323
);
2424
});

frontend/discourse/tests/fixtures/topic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5619,7 +5619,7 @@ export default {
56195619
avatar_template: "/images/avatar.png",
56205620
created_at: "2020-07-24T17:50:17.274Z",
56215621
cooked:
5622-
"<aside class=\"onebox allowlistedgeneric\" data-onebox-src=\"https://example.com/57350945\"><header class=\"source\"><a href=\"https://example.com/57350945\" target=\"_blank\" rel=\"noopener\">XYZ News Site</a> </header> <article class=\"onebox-body\"> <div class=\"aspect-image\" style=\"--aspect-ratio:690/388;\"><img src=\"/assets/logo.png\" class=\"thumbnail d-lazyload\" width=\"690\" height=\"388\"></div> <h3><a href=\"https://example.com/57350945\" target=\"_blank\" rel=\"noopener\">News Headline</a></h3> <p>Article summary</p> </article> <div class=\"onebox-metadata\"> </div> <div style=\"clear: both\"></div> </aside>",
5622+
"<aside class=\"onebox allowlistedgeneric\" data-onebox-src=\"https://example.com/57350945\"><header class=\"source\"><a href=\"https://example.com/57350945\" target=\"_blank\" rel=\"noopener\">XYZ News Site</a> </header> <article class=\"onebox-body\"> <div class=\"aspect-image\" style=\"--aspect-ratio:690/388;\"><img src=\"/images/discourse-logo-sketch.png\" class=\"thumbnail d-lazyload\" width=\"690\" height=\"388\"></div> <h3><a href=\"https://example.com/57350945\" target=\"_blank\" rel=\"noopener\">News Headline</a></h3> <p>Article summary</p> </article> <div class=\"onebox-metadata\"> </div> <div style=\"clear: both\"></div> </aside>",
56235623
post_number: 3,
56245624
post_type: 1,
56255625
updated_at: "2020-07-24T17:50:17.274Z",
@@ -5964,7 +5964,7 @@ export default {
59645964
avatar_template: "/images/avatar.png",
59655965
created_at: "2020-07-24T17:50:17.274Z",
59665966
cooked:
5967-
"<aside class=\"onebox allowlistedgeneric\" data-onebox-src=\"https://example.com/57350945\"><header class=\"source\"><a href=\"https://example.com/57350945\" target=\"_blank\" rel=\"noopener\">XYZ News Site</a> </header> <article class=\"onebox-body\"> <div class=\"aspect-image\" style=\"--aspect-ratio:690/388;\"><img src=\"/assets/logo.png\" class=\"thumbnail d-lazyload\" width=\"690\" height=\"388\"></div> <h3><a href=\"https://example.com/57350945\" target=\"_blank\" rel=\"noopener\">News Headline</a></h3> <p>Article summary</p> </article> <div class=\"onebox-metadata\"> </div> <div style=\"clear: both\"></div> </aside>",
5967+
"<aside class=\"onebox allowlistedgeneric\" data-onebox-src=\"https://example.com/57350945\"><header class=\"source\"><a href=\"https://example.com/57350945\" target=\"_blank\" rel=\"noopener\">XYZ News Site</a> </header> <article class=\"onebox-body\"> <div class=\"aspect-image\" style=\"--aspect-ratio:690/388;\"><img src=\"/images/discourse-logo-sketch.png\" class=\"thumbnail d-lazyload\" width=\"690\" height=\"388\"></div> <h3><a href=\"https://example.com/57350945\" target=\"_blank\" rel=\"noopener\">News Headline</a></h3> <p>Article summary</p> </article> <div class=\"onebox-metadata\"> </div> <div style=\"clear: both\"></div> </aside>",
59685968
post_number: 3,
59695969
post_type: 1,
59705970
updated_at: "2020-07-24T17:50:17.274Z",

frontend/discourse/tests/helpers/site-settings.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import { createSiteSettingsFromPreloaded } from "discourse/services/site-setting
22

33
const CLIENT_SETTING_TEST_OVERRIDES = {
44
title: "QUnit Discourse Tests",
5-
site_logo_url: "/assets/logo.png",
6-
site_logo_small_url: "/assets/logo-single.png",
5+
site_logo_url: "/images/discourse-logo-sketch.png",
6+
site_logo_small_url: "/images/discourse-logo-sketch-small.png",
77
site_mobile_logo_url: "",
88
site_favicon_url: "/images/discourse-logo-sketch-small.png",
99
enable_twitter_logins: true,

0 commit comments

Comments
 (0)