Skip to content

Support Node LTS #15

@dsherret

Description

@dsherret

Running this example:

const { Deno } = require("deno.ns");

I get the following in Node v14.17.1:

> node test.js
node_modules\deno.ns\dist\deno\stable\classes\PermissionStatus.js:7
class PermissionStatus extends EventTarget {
                               ^

ReferenceError: EventTarget is not defined
    at Object.<anonymous> (node_modules\deno.ns\dist\deno\stable\classes\PermissionStatus.js:7:32)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:14)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:92:18)
    at Object.<anonymous> (node_modules\deno.ns\dist\deno\stable\classes\Permissions.js:5:31)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)

This is because EventTarget was not a global until node v15 I think (works in 16). Current LTS version of node is v14. We should try to support at least Node LTS.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions