Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding subnav #1201

Merged
merged 2 commits into from
Nov 27, 2024
Merged

adding subnav #1201

merged 2 commits into from
Nov 27, 2024

Conversation

thisisjofrank
Copy link
Collaborator

No description provided.

philhawksworth
philhawksworth approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@philhawksworth philhawksworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
When we get chance to do a deeper refactor, we'll be able to lean on various in-built Lume tools for breadcrumbs and navigation.

But all good for now :)

@thisisjofrank thisisjofrank merged commit f4d19b3 into learning-center Nov 27, 2024
@thisisjofrank thisisjofrank deleted the learning-subnav branch November 27, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philhawksworth philhawksworth philhawksworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisjofrank @philhawksworth