Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --unstable-sql flag to formatter options #1198

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

kotkifotki
Copy link
Contributor

This pull request introduces the addition of the --unstable-sql flag, as introduced in denoland/deno#26750, to the options of the formatter.

@kotkifotki
Copy link
Contributor Author

Before proceeding with the merge, I would like to discuss whether the values used in the deno.json file should also be included, in addition to the flags. Currently, attempting to use these values results in a parsing error:

kotkifotki@laptop deno-project % deno fmt
error: Failed to parse "fmt" configuration

Caused by:
    unknown field `single-quote`, expected one of `useTabs`, `lineWidth`, `indentWidth`, `singleQuote`, `proseWrap`, `semiColons`, `options`, `include`, `exclude`, `files`

I would appreciate feedback on whether including these values is reasonable.

@kotkifotki kotkifotki changed the title fix: add unstable-sql flag to formatter options fix: add unstable-sql flag to formatter options Nov 27, 2024
@kotkifotki kotkifotki changed the title fix: add unstable-sql flag to formatter options fix: add --unstable-sql flag to formatter options Nov 27, 2024
@kt3k
Copy link
Member

kt3k commented Nov 29, 2024

I would like to discuss whether the values used in the deno.json file should also be included, in addition to the flags.

There's a link below the table, which links to this page that describes those deno.json fields.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@kt3k kt3k merged commit 3488cd4 into denoland:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants