feat(unstable): repurpose --unstable-detect-cjs to attempt loading more modules as cjs
#27094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re modules as cjs
|
I actually much prefer using a package.json with type commonjs than this flag but that doesn't seem to work with relative import |
bartlomieju
approved these changes
Nov 27, 2024
| @@ -4373,7 +4374,7 @@ impl CommandExt for Command { | |||
| ).arg( | |||
| Arg::new("unstable-detect-cjs") | |||
| .long("unstable-detect-cjs") | |||
| .help("Reads the package.json type field in a project to treat .js files as .cjs") | |||
| .help("Treats ambiguous .js, .jsx, .ts, .tsx files as CommonJS modules in more cases") | |||
| .value_parser(FalseyValueParser::new()) | |||
| .action(ArgAction::SetTrue) | |||
| .hide(true) | |||
There was a problem hiding this comment.
I thought so too, but all of the unstable flags seem hidden
There was a problem hiding this comment.
Oh, just make sure it's shown when you do deno run --help=unstable
bartlomieju
pushed a commit
that referenced
this pull request
Nov 28, 2024
…more modules as cjs (#27094) This resurrects the `--unstable-detect-cjs` flag (which became stable), and repurposes it to attempt loading .js/.jsx/.ts/.tsx files as CJS in the following additional scenarios: 1. There is no package.json 1. There is a package.json without a "type" field Also cleans up the implementation of this in the LSP a lot by hanging `resolution_mode()` off `Document` (didn't think about doing that until now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resurrects the
--unstable-detect-cjsflag (which became stable), and repurposes it to attempt loading .js/.jsx/.ts/.tsx files as CJS in the following additional scenarios:Also cleans up the implementation of this in the LSP a lot by hanging
resolution_mode()offDocument(didn't think about doing that until now).Related issues: