fix(node/fs): missing uv error context for readFile #27011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dart's Node wrapper code in npm:sass does string slicing on the thrown error message which broke because of our missing uv error context
bartlomieju
pushed a commit
that referenced
this pull request
Nov 28, 2024
Dart's Node wrapper code in `npm:sass` does string slicing on the thrown
error message which broke because of our missing uv error context.
Code in question:
```js
_systemErrorToFileSystemException0(callback) {
var error, t1, exception, t2;
try {
t1 = callback.call$0();
return t1;
} catch (exception) {
error = A.unwrapException(exception);
if (!type$.JsSystemError._is(error))
throw exception;
t1 = error;
t2 = J.getInterceptor$x(t1);
throw A.wrapException(new A.FileSystemException0(J.substring$2$s(t2.get$message(t1), (A.S(t2.get$code(t1)) + ": ").length, J.get$length$asx(t2.get$message(t1)) - (", " + A.S(t2.get$syscall(t1)) + " '" + A.S(t2.get$path(t1)) + "'").length), J.get$path$x(error)));
}
}
```
Fixes #26994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart's Node wrapper code in
npm:sassdoes string slicing on the thrown error message which broke because of our missing uv error context.Code in question:
Fixes #26994