Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support non-function exports in Wasm modules #26992

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix: support non-function exports in Wasm modules #26992

merged 4 commits into from
Nov 22, 2024
+26 −7

Conversation

bartlomieju
Copy link
Member

Closes #26986

dsherret
dsherret approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) November 22, 2024 00:09
@bartlomieju bartlomieju merged commit 5ca47ee into denoland:main Nov 22, 2024
17 checks passed
@bartlomieju bartlomieju deleted the wasm_module branch November 22, 2024 01:05
bartlomieju added a commit that referenced this pull request Nov 28, 2024
@bartlomieju
fix: support non-function exports in Wasm modules (#26992)
9236786 
Closes #26986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasm modules are missing non-function exports
2 participants
@bartlomieju @dsherret