feat(lint): Add checked files to JsonLintReporter #26936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
skeithtan
force-pushed
the
add-checked-files-to-jsonlintreporter
branch
from
3ac7ae4
to
91f6ec5
Compare
skeithtan
force-pushed
the
add-checked-files-to-jsonlintreporter
branch
5 times, most recently
from
bd4b10b
to
7ac14bf
Compare
skeithtan
force-pushed
the
add-checked-files-to-jsonlintreporter
branch
2 times, most recently
from
45431b0
to
02767b3
Compare
skeithtan
force-pushed
the
add-checked-files-to-jsonlintreporter
branch
from
02767b3
to
57d952c
Compare
skeithtan
force-pushed
the
add-checked-files-to-jsonlintreporter
branch
from
57d952c
to
25cf21d
Compare
bartlomieju
reviewed
Nov 20, 2024
cli/tools/lint/reporters.rs
Outdated
Comment on lines
215
to
216
| if !self.checked_files.contains(&d.specifier.to_string()) { | ||
| self.checked_files.push(d.specifier.to_string()); |
There was a problem hiding this comment.
To have the consistent format this should probably do d.specifier.to_file_path()
bartlomieju
reviewed
Nov 20, 2024
| @@ -175,6 +175,7 @@ struct JsonLintReporter { | |||
| version: u8, | |||
| diagnostics: Vec<JsonLintDiagnostic>, | |||
| errors: Vec<LintError>, | |||
| checked_files: Vec<String>, | |||
There was a problem hiding this comment.
I'm thinking this should be sorted just like diagnostics, you can do it in close() method
skeithtan
force-pushed
the
add-checked-files-to-jsonlintreporter
branch
3 times, most recently
from
63fb28c
to
305a7bf
Compare
skeithtan
force-pushed
the
add-checked-files-to-jsonlintreporter
branch
from
305a7bf
to
b8d6cf5
Compare
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26930