feat(compile): ability to embed local data files #26934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
dsherret
commented
Nov 19, 2024
| vfs | ||
| .add_file_at_path(&path) | ||
| .with_context(|| format!("Including {}", path.display()))?; | ||
| } |
There was a problem hiding this comment.
Files are included here.
| @@ -212,6 +214,48 @@ fn validate_output_path(output_path: &Path) -> Result<(), AnyError> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn get_module_roots_and_include_files( | |||
There was a problem hiding this comment.
Files are parsed out here. Only local files work.
I agree about that. Any way we can fix it before landing? I guess we'd have to pass additional permissions when embedding metadata into the binary. |
bartlomieju
approved these changes
Nov 19, 2024
|
Opened denoland/docs#1164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now trivial to implement due to recent changes.
Then to read:
Slightly annoying to have to give read permissions. I feel like we should allow reading files in the binary by default.
This only applies to files on the filesystem. For remote modules, that's going to have to wait for
import ... from "./data.txt" with { "type": "bytes" }or whatever it will be.Closes #20885