Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node:tls): set TLSSocket.alpnProtocol for client connections #26476

Merged
merged 3 commits into from
Oct 23, 2024
Merged

fix(node:tls): set TLSSocket.alpnProtocol for client connections #26476

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
678bb81
fix(node:tls): set TLSSocket.alpnProtocol for client side
satyarohith Oct 22, 2024
0c482a6
fix test
satyarohith Oct 22, 2024
a43857b
update message
satyarohith Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@satyarohith
satyarohith committed Oct 22, 2024
commit 0c482a6408b471f05fa19689f42a024074766410
14 changes: 9 additions & 5 deletions ext/node/polyfills/_tls_wrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,15 @@ export class TLSSocket extends net.Socket {
handle.afterConnect = async (req: any, status: number) => {
try {
const conn = await Deno.startTls(handle[kStreamBaseField], options);
const hs = await conn.handshake();
if (hs.alpnProtocol) {
tlssock.alpnProtocol = hs.alpnProtocol;
} else {
tlssock.alpnProtocol = false;
try {
const hs = await conn.handshake();
if (hs.alpnProtocol) {
tlssock.alpnProtocol = hs.alpnProtocol;
} else {
tlssock.alpnProtocol = false;
}
} catch {
// Don't interrupt "secure" event if handshake fails
}
handle[kStreamBaseField] = conn;
tlssock.emit("secure");
Expand Down