Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node:tls): set TLSSocket.alpnProtocol for client connections #26476

Merged
merged 3 commits into from
Oct 23, 2024
Merged

fix(node:tls): set TLSSocket.alpnProtocol for client connections #26476

merged 3 commits into from
Oct 23, 2024

Conversation

satyarohith
Copy link
Member

Towards #26127

@satyarohith satyarohith enabled auto-merge (squash) October 22, 2024 19:15
bartlomieju
bartlomieju reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. @littledivy any comments?

littledivy
littledivy approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satyarohith satyarohith merged commit 92ed4d3 into denoland:main Oct 23, 2024
17 checks passed
@satyarohith satyarohith deleted the add_tls_alpn_protocol branch October 23, 2024 11:37
bartlomieju pushed a commit that referenced this pull request Oct 25, 2024
@satyarohith @bartlomieju
fix(node:tls): set TLSSocket.alpnProtocol for client connections (#26476
c553666 
)

Towards #26127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satyarohith @bartlomieju @littledivy