Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/fs): copyFile with COPYFILE_EXCL should not throw if the destination doesn't exist #26360

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(node/fs): copyFile with COPYFILE_EXCL should not throw if the destination doesn't exist #26360

merged 1 commit into from
Oct 17, 2024

Conversation

nathanwhit
Copy link
Member

Fixes #26313.

We were checking for the NotFound error, but still calling the callback with the error / throwing.

dsherret
dsherret approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit nathanwhit enabled auto-merge (squash) October 17, 2024 19:31
@nathanwhit nathanwhit merged commit 9fde5cb into denoland:main Oct 17, 2024
17 checks passed
@nathanwhit nathanwhit deleted the fix-copyfile-excl branch October 17, 2024 20:00
bartlomieju pushed a commit that referenced this pull request Oct 17, 2024
@nathanwhit @bartlomieju
fix(node/fs): copyFile with COPYFILE_EXCL should not throw if the d…
1919181 
…estination doesn't exist (#26360)

Fixes #26313.

We were checking for the NotFound error, but still calling the callback
with the error / throwing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails Next.js static exports
2 participants
@nathanwhit @dsherret