Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jupyter): copy kernels icons to the kernel directory #26084

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Oct 9, 2024

This should likely fix #26083.

Moving the kernel icons manually to the kernels/deno folder seems to be fixing it when testing locally:

image

Signed-off-by: Jeremy Tuloup <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

@jtpio jtpio changed the title Fix Jupyter kernel icons directory fix: Jupyter kernel icons directory Oct 9, 2024
@jtpio jtpio changed the title fix: Jupyter kernel icons directory fix(jupyter): copy kernels icons to the kernel directory Oct 10, 2024
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 19cb0d9 into denoland:main Oct 16, 2024
17 checks passed
@jtpio jtpio deleted the jupyter-kernel-icons branch October 16, 2024 13:09
bartlomieju pushed a commit that referenced this pull request Oct 17, 2024
bartlomieju pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter: kernel icons are copied to the wrong directory
3 participants