Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(byonm): support deno run npm:<package> when package is not in package.json #25981

Merged
merged 7 commits into from
Oct 2, 2024
Merged

feat(byonm): support deno run npm:<package> when package is not in package.json #25981

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bf0ba15
Start of this
dsherret Oct 1, 2024
6b5f166
with prompt, but will remove
dsherret Oct 1, 2024
adb96d1
remove prompt
dsherret Oct 1, 2024
261b116
update
dsherret Oct 1, 2024
9113259
add skip_write option to lockfile
dsherret Oct 2, 2024
9248062
add test
dsherret Oct 2, 2024
7771c06
improve test
dsherret Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove prompt
  • Loading branch information
@dsherret
dsherret committed Oct 1, 2024
commit adb96d15f3a4f57f1d9da425d8fea9b74606b61b
7 changes: 0 additions & 7 deletions cli/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,6 @@ async fn run_subcommand(flags: Arc<Flags>) -> Result<i32, AnyError> {
Err(script_err) => {
if let Some(ResolvePkgFolderFromDenoReqError::Byonm(ByonmResolvePkgFolderFromDenoReqError::UnmatchedReq(req))) = script_err.downcast_ref::<ResolvePkgFolderFromDenoReqError>() {
if flags.node_modules_dir.is_none() {
let message = format!(
concat!("Need to install the following packages:\nnpm:{}\nOk to proceed?"),
req
);
if !crate::util::console::confirm(&message, true) {
deno_core::anyhow::bail!("canceled");
}
let mut flags = flags.deref().clone();
let watch = match &flags.subcommand {
DenoSubcommand::Run(run_flags) => run_flags.watch.clone(),
Expand Down
17 changes: 0 additions & 17 deletions cli/util/console.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,3 @@ pub fn console_size() -> Option<ConsoleSize> {
let stderr = &deno_runtime::deno_io::STDERR_HANDLE;
deno_runtime::ops::tty::console_size(stderr).ok()
}

pub fn confirm(text: &str, default: bool) -> bool {
if !std::io::stderr().is_terminal() {
return default;
}
let default_str = if default { "(y)" } else { "(n)" };
eprint!("{} {} > ", text, default_str);
let _ = std::io::stderr().flush();
let mut input = String::new();
let _ = std::io::stdin().read_line(&mut input);
let input = input.trim().to_lowercase();
if input.is_empty() {
default
} else {
input == "y" || input == "yes"
}
}