Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(byonm): support deno run npm:<package> when package is not in package.json #25981

Merged
merged 7 commits into from
Oct 2, 2024
Merged

feat(byonm): support deno run npm:<package> when package is not in package.json #25981

merged 7 commits into from
Oct 2, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 2, 2024

Closes #25905

bartlomieju
bartlomieju approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit cac28b5 into denoland:main Oct 2, 2024
17 checks passed
@dsherret dsherret deleted the support_remote_npm_not_in_lockfile_byonm branch October 2, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno run npm:<package> with package.json fails if package not present in deps
3 participants
@dsherret @marvinhagemeister @bartlomieju