Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): remove unimplemented promiseHook stubs #25979

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix(ext/node): remove unimplemented promiseHook stubs #25979

merged 1 commit into from
Oct 2, 2024

Conversation

littledivy
Copy link
Member

temporalio sdk will try to use promiseHook if it is found. This patch removes the unimplemented stubs.

    if (promiseHooks) {
      // Node >=16.14 only
      this.stopPromiseHook = promiseHooks.createHook({
        init: (promise: Promise<unknown>, parent: Promise<unknown>) => {

Fixes #25977

@littledivy littledivy merged commit 620e6b4 into denoland:main Oct 2, 2024
17 checks passed
@littledivy littledivy deleted the rm_promiseHook_stubs branch October 2, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno 2.0.0-rc.9 - Error: Not implemented: v8.promiseHooks.createHook
2 participants
@littledivy @satyarohith