fix(info): error instead of panic for npm specifiers when using byonm #25947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the time being
dsherret
commented
Sep 30, 2024
| } else if NpmPackageReqReference::from_str(&run_flags.script) | ||
| .is_ok() | ||
| { | ||
| ModuleSpecifier::parse(&run_flags.script)? |
There was a problem hiding this comment.
This check was useless. It's done in the else condition.
marvinhagemeister
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the time being. We need to decide how this should behave.
It was panicking because npm specifier entrypoints aren't resolved anywhere except for
deno run(it resolves the binary entrypoint).Closes #25903