fix(console/ext/repl): support using parseFloat() #25900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1/my_deno into log_format_specifiers
…1/my_deno into log_format_specifiers
|
@dsherret Can you please review this PR |
|
@bartlomieju Can you please review this |
Co-authored-by: tannal <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #21428
This issue has a pull request that has been open for a long time without resolving its problems, so I wanted to take this issue and solve it.
First, I modified 01_console.js, then I modified repl_tests.rs.
Next, I created a test under repl/console_log to check if the float type is supported by running 093_console_log_format.js and comparing the output with 093_console_log_format.out.
Finally, console_tests.rs was modified to fix assertions related to this issue.
Ps: @tannal worked on it before