Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check): ignore noImplicitOverrides in remote modules #25854

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(check): ignore noImplicitOverrides in remote modules #25854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cli/tsc/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ impl Diagnostic {
pub fn include_when_remote(&self) -> bool {
/// TS6133: value is declared but its value is never read (noUnusedParameters and noUnusedLocals)
const TS6133: u64 = 6133;
self.code != TS6133
/// TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'X'.
const TS4114: u64 = 4114;
!matches!(self.code, TS6133 | TS4114)
}

fn fmt_category_and_code(&self, f: &mut fmt::Formatter) -> fmt::Result {
Expand Down
4 changes: 4 additions & 0 deletions tests/specs/check/remote_missing_override/__test__.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"args": "check --all main.ts",
"output": "Download [WILDLINE]\nCheck [WILDLINE]\n"
}
1 change: 1 addition & 0 deletions tests/specs/check/remote_missing_override/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import "http://localhost:4545/check/missing_override.ts";
10 changes: 10 additions & 0 deletions tests/testdata/check/missing_override.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export class Base {
method() {
}
}

export class Derived extends Base {
// missing override keyword
method() {
}
}