fix(fmt): --check was broken for CSS, YAML and HTML #25848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Sep 24, 2024
M4RC3L05
added a commit
to M4RC3L05/deno
that referenced
this pull request
Nov 22, 2024
Similar with denoland#25848, we need to make `format_sql` to return `None` so we do not flag wel formatted sql files and being wrong Signed-off-by: m4rc3l05 <[email protected]>
M4RC3L05
added a commit
to M4RC3L05/deno
that referenced
this pull request
Nov 22, 2024
Similar with denoland#25848, we need to make `format_sql` to return `None` so we do not flag well formatted sql files and being wrong Signed-off-by: m4rc3l05 <[email protected]>
M4RC3L05
added a commit
to M4RC3L05/deno
that referenced
this pull request
Nov 22, 2024
Similar with denoland#25848, we need to make `format_sql` to return `None` so we do not flag well formatted sql files as being wrong Signed-off-by: m4rc3l05 <[email protected]>
dsherret
pushed a commit
that referenced
this pull request
Nov 22, 2024
Similar with #25848, we need to make `format_sql` to return `None` so we do not flag well formatted sql files as being wrong. Signed-off-by: m4rc3l05 <[email protected]>
bartlomieju
pushed a commit
that referenced
this pull request
Nov 28, 2024
Similar with #25848, we need to make `format_sql` to return `None` so we do not flag well formatted sql files as being wrong. Signed-off-by: m4rc3l05 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deno fmt --checkwas broken for CSS, YAML and HTML files.Before this PR, formatting any of these file types would return a string,
even though the contract in
cli/tools/fmt.rsis to only return a stringif the formatting changed. This causes wrong flagging of these files
as being badly formatted even though diffs showed nothing (because
they were in fact formatted properly).
Closes #25840