feat(fmt): support vto and njk extensions #25831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you rebase and add a test like the one in |
|
Sorry for the number of commits. I messed up a little. I your prefer a new cleaner PR, no problem. I've added the test files, let me know if it's okay (in the yaml example, there's the badly formatted file but not the fixed formatted to compare). |
lucacasonato
force-pushed
the
fmt/vto-njk
branch
from
b997c35
to
ad5d896
Compare
dsherret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25802
markup_fmt plugin supports some HTML-like formats like Angular, Jinja, Twig, Nunjucks or Vento, that are not supported by
deno fmt. This PR adds support for the extensionsnjk(Nunjucks) andvto(Vento). Angular doesn't have a custom extension (it useshtmlafaik) and Jinja and Twig are template engines written in Python and PHP respectively so it doesn't make sense to be supported by Deno.