Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panic when require(esm) #25769

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: panic when require(esm) #25769

merged 1 commit into from
Sep 20, 2024

Conversation

bartlomieju
Copy link
Member

Upgrades deno_core.

Closes #25761
Closes #25738

@bartlomieju
Copy link
Member Author

@devsnek can you add some tests?

@devsnek
Copy link
Member

devsnek commented Sep 20, 2024

@bartlomieju i was never able to make a minimal reproduction of the problem, but i feel like npm at least is popular enough we could smoke test it.

@bartlomieju
Copy link
Member Author

@littledivy could you add a smoke test for npm CLI?

@bartlomieju bartlomieju merged commit 55c22ee into denoland:main Sep 20, 2024
17 checks passed
@bartlomieju bartlomieju deleted the upgrade_deno_core branch September 20, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic with 2.0.0-rc4 Deno 2 panicked running npm cli
2 participants
@bartlomieju @devsnek