Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(ext/ffi): remove deprecated UnsafeFnPointer constructor type with untyped Deno.PointerObject parameter #25577

Conversation

aapoalas
Copy link
Collaborator

No description provided.

@iuioiua iuioiua changed the title BREAKING(ext/ffi): Remove deprecated UnsafeFnPointer constructor type with untyped Deno.PointerObject parameter BREAKING(ext/ffi): remove deprecated UnsafeFnPointer constructor type with untyped Deno.PointerObject parameter Sep 11, 2024
@iuioiua
Copy link
Contributor

iuioiua commented Sep 15, 2024

Can you please fix the failing test, @aapoalas?

@aapoalas
Copy link
Collaborator Author

Can you please fix the failing test, @aapoalas?

Fixed

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit f8547e2 into denoland:main Sep 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants