Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add better error messages for unstable APIs #25519

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

bartlomieju
Copy link
Member

This commit improves error messages for unstable APIs:

  • --unstable-broadcast-channel
  • --unstable-cron
  • --unstable-http
  • --unstable-kv
  • --unstable-temporal

By providing information and hints what went wrong and how the
error can be fixed. It reuses the same infra that was added in
#21764.

@bartlomieju bartlomieju added this to the 2.0.0-rc.2 milestone Sep 9, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bartlomieju bartlomieju merged commit 04a9cc9 into denoland:main Sep 9, 2024
17 checks passed
@bartlomieju bartlomieju deleted the unstable_api_error branch September 9, 2024 20:52
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Sep 9, 2024
This commit improves error messages for unstable APIs:
- `--unstable-broadcast-channel`
- `--unstable-cron`
- `--unstable-http`
- `--unstable-kv`
- `--unstable-temporal`

By providing information and hints what went wrong and how the
error can be fixed. It reuses the same infra that was added in 
denoland#21764.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants