Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(buffer): remove Deno.Buffer #25441

Merged
merged 6 commits into from
Sep 6, 2024
Merged

BREAKING(buffer): remove Deno.Buffer #25441

merged 6 commits into from
Sep 6, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 5, 2024

Towards #22079

marvinhagemeister
marvinhagemeister approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that we had Deno.Buffer

@iuioiua iuioiua merged commit d8f3123 into denoland:main Sep 6, 2024
17 checks passed
@iuioiua iuioiua deleted the remove-deno-buffer branch September 6, 2024 08:28
@iuioiua iuioiua mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iuioiua @marvinhagemeister @bartlomieju