Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: remove deno bundle #25339

Merged
merged 6 commits into from
Sep 2, 2024
Merged

BREAKING: remove deno bundle #25339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c09e9a8
BREAKING: remove `deno bundle`
iuioiua Sep 1, 2024
e0b4092
work
iuioiua Sep 1, 2024
d297c43
fixes and work
iuioiua Sep 1, 2024
376c613
work
iuioiua Sep 1, 2024
4a16282
adjustments
iuioiua Sep 1, 2024
c54b4a4
fix
iuioiua Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adjustments
  • Loading branch information
@iuioiua
iuioiua committed Sep 1, 2024
commit 4a1628269877065d5b5834ce700b5add6ce45f84
3 changes: 2 additions & 1 deletion cli/args/flags.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,7 +1642,8 @@ glob {*_,*.,}bench.{js,mjs,ts,mts,jsx,tsx}:

fn bundle_subcommand() -> Command {
command("bundle", "⚠️ `deno bundle` was removed in Deno 2.
See the Deno 1.x to 2.x Migration Guide for migration instructions: https://docs.deno.com/runtime/manual/advanced/migrate_deprecations", UnstableArgsConfig::ResolutionOnly)

See the Deno 1.x to 2.x Migration Guide for migration instructions: https://docs.deno.com/runtime/manual/advanced/migrate_deprecations", UnstableArgsConfig::ResolutionOnly)
.hide(true)
}

Expand Down
2 changes: 1 addition & 1 deletion cli/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ async fn run_subcommand(flags: Arc<Flags>) -> Result<i32, AnyError> {
tools::bench::run_benchmarks(flags, bench_flags).await
}
}),
DenoSubcommand::Bundle => exit_with_message("⚠️ `deno bundle` was removed in Deno 2.\nSee the Deno 1.x to 2.x Migration Guide for migration instructions: https://docs.deno.com/runtime/manual/advanced/migrate_deprecations", 1),
DenoSubcommand::Bundle => exit_with_message("⚠️ `deno bundle` was removed in Deno 2.\n\nSee the Deno 1.x to 2.x Migration Guide for migration instructions: https://docs.deno.com/runtime/manual/advanced/migrate_deprecations", 1),
DenoSubcommand::Doc(doc_flags) => {
spawn_subcommand(async { tools::doc::doc(flags, doc_flags).await })
}
Expand Down
1 change: 1 addition & 0 deletions tests/specs/bundle/removed/bundle.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
error: ⚠️ `deno bundle` was removed in Deno 2.

See the Deno 1.x to 2.x Migration Guide for migration instructions: https://docs.deno.com/runtime/manual/advanced/migrate_deprecations
1 change: 1 addition & 0 deletions tests/specs/bundle/removed/bundle_help.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
⚠️ `deno bundle` was removed in Deno 2.

See the Deno 1.x to 2.x Migration Guide for migration instructions: https://docs.deno.com/runtime/manual/advanced/migrate_deprecations

Usage: deno bundle [OPTIONS]
Expand Down
Loading