Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: remove deno bundle #25339

Merged
merged 6 commits into from
Sep 2, 2024
Merged

BREAKING: remove deno bundle #25339

merged 6 commits into from
Sep 2, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 1, 2024 •
edited
Loading

deno bundle now produces:

error: ⚠️ `deno bundle` was removed in Deno 2.

See the Deno 1.x to 2.x Migration Guide for migration instructions: https://docs.deno.com/runtime/manual/advanced/migrate_deprecations

deno bundle --help now produces:

⚠️ `deno bundle` was removed in Deno 2.

See the Deno 1.x to 2.x Migration Guide for migration instructions: https://docs.deno.com/runtime/manual/advanced/migrate_deprecations

Usage: deno bundle [OPTIONS]

Options:
  -q, --quiet     Suppress diagnostic output
      --unstable  Enable all unstable features and APIs. Instead of using this flag, consider enabling individual unstable features
                    To view the list of individual unstable feature flags, run this command again with --help=unstable

Towards #22079

@iuioiua iuioiua added the ci-draft Run the CI on draft PRs. label Sep 1, 2024
@iuioiua iuioiua mentioned this pull request Sep 1, 2024
Closed
@iuioiua iuioiua removed the ci-draft Run the CI on draft PRs. label Sep 2, 2024
@iuioiua iuioiua marked this pull request as ready for review September 2, 2024 01:56
lucacasonato
lucacasonato approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@lucacasonato lucacasonato merged commit bc51eca into denoland:main Sep 2, 2024
33 checks passed
@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 2, 2024

I wonder if there are any crates we can trim now because of this PR. Haven't looked into it yet...

@iuioiua iuioiua deleted the remove-bundle branch September 2, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @lucacasonato