fix(ext/node): use primordials in ext/node/polyfills/internal/buffer.mjs
#24993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We effectively vendor this file. I'm not sure if it's worth using primordials here. Feels like it's gonna make updates a lot harder. That said we only update it a couple times per year, so maybe it's not such a big deal? |
|
IMHO, primordials are hard to introduce, but then updating the codes is not so hard. |
|
Since Node.js also uses primordials, the diffs with the Deno impl may decrease and make it rather easy to update. |
|
@petamoriken, sorry for a slow response. I was wrong, it's not this file that we vendor so this should be fine. Can you please rebase the PR? |
petamoriken
force-pushed
the
fix/primordials-node-internal-buffer
branch
from
2eb4059
to
050d09d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #24236