fix(node): Implement os.userInfo properly, add missing toPrimitive
#24702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext/node/ops/os/mod.rs
Outdated
| where | ||
| P: NodePermissions + 'static, | ||
| { | ||
| { | ||
| let permissions = state.borrow_mut::<P>(); | ||
| permissions.check_sys("username", "node:os.userInfo()")?; | ||
| permissions.check_sys("userInfo", "node:os.userInfo()")?; |
There was a problem hiding this comment.
You'll also have to update parse_sys_kind - or just revert back to username. Probably doesn't matter all too much 😆
bartlomieju
pushed a commit
that referenced
this pull request
Nov 5, 2024
#24702) Fixes the implementation of `os.userInfo`, and adds a missing `toPrimitive` for `tmpdir`. This allows us to enable the corresponding node_compat test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the implementation of
os.userInfo, and adds a missingtoPrimitivefortmpdir. This allows us to enable the corresponding node_compat test.